-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix torch state sync issues #842
Merged
navaronbracke
merged 15 commits into
juliansteenbakker:master
from
navaronbracke:fix_torch_on_start
Oct 31, 2023
Merged
fix: Fix torch state sync issues #842
navaronbracke
merged 15 commits into
juliansteenbakker:master
from
navaronbracke:fix_torch_on_start
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopedro735
pushed a commit
to joaopedro735/mobile_scanner
that referenced
this pull request
Aug 22, 2024
…_on_start fix: Fix torch state sync issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the torch state was not properly synced with the notifier.
Android, iOS and MacOS use callbacks to notify when their observable torch state has changed.
However, the plugin also manually set the torch state, which made it go out-of-sync.
Changelog:
toggleTorch
, if the device is null, do nothingprint()
calls, instead adding a comment why exceptions are ignoredisTorchAvailable
besideshasTorch
for iOS. This is some work towards making UsesharedDarwinSource
to share MacOS and iOS implementation details #782 easier.error.localisedDescription
as message forFlutterError
, rather than putting it in the code fieldcontainsKey()
with a nullable value access in the web plugin. This reads a bit better, and provides type promotion for the variable.TorchState.off
when the camera is stoppedThe last two fixes listed here probably fixed the out-of-sync issue of #833
Fixes #833