Repository navigation
Replace add_bridged_constraint override by a default reformulation hook - #81
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 662 655 -7
=========================================
- Hits 662 655 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The override copied MOI's internal implementation of add_bridged_constraint, including Constraint.add_key_for_bridge whose signature changes in jump-dev/MathOptInterface.jl's index-space redesign. Since recursive_model(::Optimizer) is the Optimizer itself, the NonlinearBridge can read the default reformulation from the model it receives instead.
blegat
force-pushed
the
bl/remove-add-bridged-constraint
branch
from
November 6, 2026 07:07
8a1f28d to
d763c82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More robust than current approach which breaks with jump-dev/MathOptInterface.jl#3013