-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the footer with link lists #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me - for style, what do you think about centering this 3-column list of projects, so there's not so much whitespace to the right, and so it follows page content structure more closely?
The trick there is that they will lose their shared left alignment with the logo and copyright text at the bottom. I suspect the happy medium would be some kind of max width set on all content in the footer, which would prevent the flow from leaving a lot of space to the right on large device widths. However, considering the rest of the page design, there's not an obvious value to set that at. I could go with the "content--wide" width now set for art on the interior pages. |
Good point - your proposed solution sounds good to me! |
For the lower part, could we use white text color? C-f #587 |
+1 from me - it does makes sense that white would be more accessible |
@palewire what do you think about the proposal to have white text in the footer? |
Was hoping to put in sometime mocking up alternatives and then getting them tested, not just by Lighthouse, but also by the alternative standard mentioned in the issue. I haven't made time for that yet. My hope would be that with a little experimentation we could use that method to settle on one color that would work in both sections of the footer, just for consistency's sake. Maybe I'm overthinking it. |
sounds good - no hurry, just wanted to make sure you saw the conversation. Want to do that before finishing this PR? Or open an issue to focus on the footer color and add it to the milestone? |
I'm okay either way. I just want to make sure we ultimately nail down a solid approach we can point to standards with. That can be now, or it can be later. |
@krassowski would you mind if we tracked the footer text color in a dedicated issue? I think the addition of the links here is a nice addition, so I'm inclined to move forward in the name of iterative progress, but what do you think? |
I'm fine with that :). I would suggest a rebase/merge of master before merging into matter to double check that validator and links check passes. |
…into bigger-footer
Master is rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thanks for this improvement!
(note that I didn't see this in the PR preview, not sure why the behavior is different) |
I suspect this is a caching issue that will resolve once the TTL expires. But I could be wrong. |
yep you're right, it's fixed now |
This fixes #601.
Before:
After: