Merge pull request #347 from minrk/403-on-fail

403 on failed auth for EventStream
jupyterhub · Mar 29, 2024 · 79784e0 · 79784e0
2 parents 518c9c8 + bbfd41c
commit 79784e0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/nbgitpuller/handlers.py b/nbgitpuller/handlers.py
@@ -29,6 +29,12 @@ def __init__(self, *args, **kwargs):
         if 'git_lock' not in self.settings:
             self.settings['git_lock'] = locks.Lock()
 
+    def get_login_url(self):
+        # raise on failed auth, not redirect
+        # can't redirect EventStream to login
+        # same as Jupyter's APIHandler
+        raise web.HTTPError(403)
+
     @property
     def git_lock(self):
         return self.settings['git_lock']

diff --git a/tests/test_api.py b/tests/test_api.py
@@ -136,7 +136,7 @@ def test_clone_auth(jupyterdir, jupyter_server):
         }
         r = request_api(params)
         # no token, redirect to login
-        assert r.code == 302
+        assert r.code == 403
 
 
 def test_clone_targetpath(jupyterdir, jupyter_server):