Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to support multusMasterCNI in Thick Plugin #1245

Closed
wants to merge 2 commits into from

Conversation

raghs-aws
Copy link

@@ -92,7 +96,26 @@ Below you can see an example of the daemon configuration:
"multusAutoconfigDir": "/host/etc/cni/net.d"
}
```
#### Example 2 (Configure Master CNI):
In this case you can define your primary CNI conffile as ```multusMasterCNI``` as present in the ```multusAutoconfigDir```. This is helpful when you have multiple CNIs and in same usecases or race conditions, multus selects the unintended CNI as primary CNIs. In this case similar to option 1 all other configurations are automatically created but primary CNI remains fixed. Below example configures vpc cni (10-aws.conflist) as primary CNI, you can change it to your primary CNI conf such as calico, flannel etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use a cloud agnostic name here (10-cloudprovider.conflist)

"cniConfigDir": "/host/etc/cni/net.d",
"multusConfigFile": "auto",
"multusAutoconfigDir": "/host/etc/cni/net.d",
"multusMasterCNI": "10-aws.conflist"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line too, thanks!

@coveralls
Copy link

Coverage Status

coverage: 62.778%. remained the same
when pulling bd40b99 on raghs-aws:master
into 0fd3fa7 on k8snetworkplumbingwg:master.

@raghs-aws
Copy link
Author

raghs-aws commented Apr 1, 2024

@dougbtv Added new changes as requested to refer cloud agnostic config as 10-cloudprovider.conflist

@raghs-aws raghs-aws requested a review from dougbtv April 29, 2024 20:01
Copy link

github-actions bot commented Aug 8, 2024

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants