-
Notifications
You must be signed in to change notification settings - Fork 178
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #517 from almaslennikov/pkey-selector
Allow to filter net devices by Infiniband Partition Key
- Loading branch information
Showing
28 changed files
with
446 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package resources | ||
|
|
||
| import ( | ||
| "github.com/k8snetworkplumbingwg/sriov-network-device-plugin/pkg/types" | ||
| ) | ||
|
|
||
| type pKeySelector struct { | ||
| pKeys []string | ||
| } | ||
|
|
||
| // NewPKeySelector returns a DeviceSelector interface to filter devices based on available PKeys | ||
| func NewPKeySelector(pKeys []string) types.DeviceSelector { | ||
| return &pKeySelector{pKeys: pKeys} | ||
| } | ||
|
|
||
| func (ds *pKeySelector) Filter(inDevices []types.HostDevice) []types.HostDevice { | ||
| filteredList := make([]types.HostDevice, 0) | ||
|
|
||
| for _, dev := range inDevices { | ||
| pKey := dev.(types.PciNetDevice).GetPKey() | ||
| if pKey != "" && contains(ds.pKeys, pKey) { | ||
| filteredList = append(filteredList, dev) | ||
| } | ||
| } | ||
|
|
||
| return filteredList | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package resources_test | ||
|
|
||
| import ( | ||
| "github.com/k8snetworkplumbingwg/sriov-network-device-plugin/pkg/resources" | ||
| "github.com/k8snetworkplumbingwg/sriov-network-device-plugin/pkg/types" | ||
| "github.com/k8snetworkplumbingwg/sriov-network-device-plugin/pkg/types/mocks" | ||
|
|
||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| var _ = Describe("PKeySelector", func() { | ||
| Describe("PKey selector", func() { | ||
| Context("filtering", func() { | ||
| It("should return devices matching given PKeys", func() { | ||
| pKeys := []string{"0x1", "0x2"} | ||
| sel := resources.NewPKeySelector(pKeys) | ||
|
|
||
| dev0 := mocks.PciNetDevice{} | ||
| dev0.On("GetPKey").Return("0x1") | ||
|
|
||
| dev1 := mocks.PciNetDevice{} | ||
| dev1.On("GetPKey").Return("0x2") | ||
|
|
||
| dev2 := mocks.PciNetDevice{} | ||
| dev2.On("GetPKey").Return("0x3") | ||
|
|
||
| in := []types.HostDevice{&dev0, &dev1, &dev2} | ||
| filtered := sel.Filter(in) | ||
|
|
||
| Expect(filtered).To(ContainElement(&dev0)) | ||
| Expect(filtered).To(ContainElement(&dev1)) | ||
| Expect(filtered).NotTo(ContainElement(&dev2)) | ||
| }) | ||
| }) | ||
| }) | ||
| }) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.