Add test GitHub action #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
reviewed
Mar 18, 2021
.github/workflows/test.yml
Outdated
| os: [ubuntu-latest] | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Set up Go 1.13 |
There was a problem hiding this comment.
The go version moves, right? So you should just add Set up go and remove the "1.13"
| - name: Install hwdata | ||
| run: sudo apt-get install hwdata -y | ||
|
|
||
| - name: Go test |
There was a problem hiding this comment.
I wonder if there is a need to run tests so many times ?
There was a problem hiding this comment.
The reason why I did it was to ensure make test is ok for each version of golang. There is a small chance here to capture bugs for sure however it is free to execute this on github, and we just have to worry about log clutter only. I think that is an ok cost. Its easy to see at a glance if pass or failed.
Merged
Signed-off-by: Kennelly, Martin <[email protected]>
|
Combined into PR #328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kennelly, Martin [email protected]
GA will fail until #331 is merged.
Issue: #327