Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recording multiple events #521

Merged

Conversation

adrianchiris
Copy link
Collaborator

In case update operation fail in node status writer we should not record an event.

move event sending logic to its own method
and call it after status has been successfully updated.

In case update operation fail in node status writer
we should not record an event.

move event sending logic to its own method
and call it after status has been successfully updated.

Signed-off-by: adrianc <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris
Copy link
Collaborator Author

@rollandf PTAL.

still need to test this one on my setup.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6560379546

  • 0 of 23 (0.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 25.18%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/writer.go 0 23 0.0%
Files with Coverage Reduction New Missed Lines %
api/v1/helper.go 3 42.04%
pkg/daemon/writer.go 3 0.0%
Totals Coverage Status
Change from base Build 6552022763: -0.003%
Covered Lines: 2270
Relevant Lines: 9015

💛 - Coveralls

Copy link
Contributor

@rollandf rollandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good catch

@adrianchiris
Copy link
Collaborator Author

This is working as expected.

There is another issue with roles in the operator following events introduction, ill send fix in a separarte PR.

@adrianchiris adrianchiris merged commit af24f18 into k8snetworkplumbingwg:master Oct 19, 2023
10 of 11 checks passed
@adrianchiris adrianchiris deleted the dont-record-same-events branch July 16, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants