-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid recording multiple events #521
Avoid recording multiple events #521
Conversation
In case update operation fail in node status writer we should not record an event. move event sending logic to its own method and call it after status has been successfully updated. Signed-off-by: adrianc <[email protected]>
Thanks for your PR,
To skip the vendors CIs use one of:
|
@rollandf PTAL. still need to test this one on my setup. |
Pull Request Test Coverage Report for Build 6560379546
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good catch
This is working as expected. There is another issue with roles in the operator following events introduction, ill send fix in a separarte PR. |
af24f18
into
k8snetworkplumbingwg:master
In case update operation fail in node status writer we should not record an event.
move event sending logic to its own method
and call it after status has been successfully updated.