Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix odd number of key-value in error logs #543

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix odd number of key-value in error logs #543

merged 1 commit into from
Nov 9, 2023

Conversation

adrianchiris
Copy link
Collaborator

No description provided.

@adrianchiris
fix odd number of key-value in error logs
7d9eca4 
a recent refactor to logging introduced these issues[1].
fix them to avoid panic during runtime

[1] c155c82

Signed-off-by: adrianc <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne e0ne mentioned this pull request Nov 9, 2023
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris
Copy link
Collaborator Author

@zeeke PTAL a quick one :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6809146161

  • 0 of 3 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.464%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 0 1 0.0%
pkg/plugins/mellanox/mellanox_plugin.go 0 1 0.0%
pkg/systemd/systemd.go 0 1 0.0%
Totals Coverage Status
Change from base Build 6744863425: 0.0%
Covered Lines: 2334
Relevant Lines: 9166
💛 - Coveralls

@mlguerrero12
Copy link
Contributor

LGTM

zeeke
zeeke approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeeke zeeke merged commit ba78e01 into k8snetworkplumbingwg:master Nov 9, 2023
11 checks passed
@adrianchiris adrianchiris deleted the fix-err-logs branch July 16, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adrianchiris @coveralls @mlguerrero12 @e0ne @zeeke