deploy: relax Operator node affinity

[EmilienM]

In the context of Hypershift (Hosted Clusters with OpenShift), where a Nodepool
(terminology for a worker Node in HCP) is not a control-plane or
a master Node but a worker, we can't force the Operator to be deployed
on a master node that doesn't exist. Instead, we want to deploy it on a
worker.

The proposal here is to relax the rule and use
preferredDuringSchedulingIgnoredDuringExecution instead so the scheduler
will try to find a master node or fallback on other nodes if not found.

[github-actions]

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[SchSeba]

LGTM

nice work!

[coveralls]

Pull Request Test Coverage Report for Build 11894643215

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 6 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.02%) to 45.584%

---

Files with Coverage Reduction	New Missed Lines	%
controllers/helper.go	1	68.75%
controllers/generic_network_controller.go	5	74.38%

Totals
Change from base Build 11775378543:	-0.02%
Covered Lines:	6874
Relevant Lines:	15080

---

💛 - Coveralls

[wizhaoredhat]

LGTM!

[SchSeba]

Hi @EmilienM can you take a quick look on the failed in the ocp lane please

[SchSeba]

please take a look on the helm deployment

sriov-network-operator/deployment/sriov-network-operator-chart/values.yaml

Lines 10 to 24 in aecb4bb

	affinity:
	nodeAffinity:
	preferredDuringSchedulingIgnoredDuringExecution:
	- weight: 1
	preference:
	matchExpressions:
	- key: "node-role.kubernetes.io/master"
	operator: In
	values: [""]
	- weight: 1
	preference:
	matchExpressions:
	- key: "node-role.kubernetes.io/control-plane"
	operator: In
	values: [""]

[SchSeba]

I think here you can use Exist and remove the values

[EmilienM]

This was copied from

sriov-network-operator/deployment/sriov-network-operator-chart/values.yaml

Lines 11 to 24 in 92fee7b

	nodeAffinity:
	preferredDuringSchedulingIgnoredDuringExecution:
	- weight: 1
	preference:
	matchExpressions:
	- key: "node-role.kubernetes.io/master"
	operator: In
	values: [""]
	- weight: 1
	preference:
	matchExpressions:
	- key: "node-role.kubernetes.io/control-plane"
	operator: In
	values: [""]

[EmilienM]

I applied your suggestion though.