Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate clientSet / informers / listers for the whereabouts types #202

Closed
wants to merge 2 commits into from
Closed

Generate clientSet / informers / listers for the whereabouts types #202

wants to merge 2 commits into from

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Feb 25, 2022 •
edited
Loading

This PR adds a clientset / informers / listers for the whereabouts types - IPPool and OverlappingRangeIPReservation .

PR #185 will be rebased with this one, and will use these generated types.

I wonder if we should run the scripts that generate these types in CI, or should do it manually when there are changes.

Depends-on:

@maiqueb maiqueb force-pushed the generate-ippool-informers-listers branch 8 times, most recently from b56a7fc to e170f79 Compare February 28, 2022 14:24
@maiqueb maiqueb changed the title WIP: Generate ippool informers listers Generate clientSet / informers / listers for the whereabouts types Feb 28, 2022
@coveralls
Copy link

coveralls commented Feb 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2038981999

  • 16 of 22 (72.73%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 40.811%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/api/whereabouts.cni.cncf.io/v1alpha1/register.go 16 22 72.73%
Totals Coverage Status
Change from base Build 2034635120: 0.3%
Covered Lines: 453
Relevant Lines: 1110
💛 - Coveralls

@maiqueb maiqueb force-pushed the generate-ippool-informers-listers branch 3 times, most recently from b395a86 to 556ea45 Compare March 1, 2022 23:33
@maiqueb maiqueb force-pushed the generate-ippool-informers-listers branch 2 times, most recently from 51eb53d to 612ca87 Compare March 11, 2022 12:54
@maiqueb maiqueb mentioned this pull request Mar 25, 2022
Merged
maiqueb added 2 commits March 25, 2022 09:37
@maiqueb
build: generate ip pool clientSet/informers/listers
66e1689 
Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb
vendor: update vendor stuff
3bfa4e2 
Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb maiqueb force-pushed the generate-ippool-informers-listers branch from 612ca87 to 3bfa4e2 Compare March 25, 2022 08:38
@maiqueb
Copy link
Collaborator Author

maiqueb commented Apr 18, 2022

Abandoning since this change was already merged in PR #185.

@maiqueb maiqueb closed this Apr 18, 2022
@maiqueb maiqueb mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiqueb @coveralls