E2e tests check stateful sets #206
Conversation
Signed-off-by: Miguel Duarte Barroso <[email protected]>
The IP reconcile loop also requires the IP ranges in a normalized format; as such, we export it into a function, which will be used in a follow-up commit. Signed-off-by: Miguel Duarte Barroso <[email protected]>
|
Hi @xagent003 . I'm trying to come up with e2e test to reproduce the issues you've reported about the leaking IP addresses. Would you take a look at the top 2 commits in this PR to see if it makes sense to you ? I have unfortunately not been able to reproduce them so far; would appreciate your help to figure out what I'm doing wrong. |
|
/cc @nicklesimba |
Pull Request Test Coverage Report for Build 1962247774
💛 - Coveralls |
maiqueb
force-pushed
the
e2e-tests-check-stateful-sets
branch
from
cdd890a to
1485df3
Compare
| return false, err | ||
| } | ||
|
|
||
| return isStatefulSetEmpty(statefulSet) && areAssociatedPodsGone(associatedPods), nil |
There was a problem hiding this comment.
Garbage collection (foreground cascading deletion) won't work for cleaning up pods, I guess?
There was a problem hiding this comment.
It does, I just haven't used it yet.
e2e/e2e_test.go
Outdated
| "range": "10.10.0.0/16", | ||
| "log_level": "debug", | ||
| "log_file": "/tmp/wb" | ||
| } |
There was a problem hiding this comment.
I don't understand this change, can you explain it please?
There was a problem hiding this comment.
I was wrong in adapting this in this PR, it is not needed, since whereabouts is only receiving the configuration for a single plugin at a time. On the other hand, it is required for the ip reconciliation loop.
If you try the test I've added in that commit without the associated code changes, you'll see it fails.
These ugly tests do not cleanup after themselves; this way, the golang based tests (which **do** cleanup after themselves) will not be impacted by these left-overs. Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
e2e-tests-check-stateful-sets
branch
from
1485df3 to
7360c64
Compare
|
Abandoning since this change is featured in (already merged PR #185 ). |
No description provided.