Repository navigation
fix(egress): let compilers leave tokenPassthrough targets unbound - #3497
Open
codyhartsook wants to merge 1 commit into
Open
codyhartsook wants to merge 1 commit into
codyhartsook wants to merge 1 commit into
Conversation
Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>
codyhartsook
marked this pull request as ready for review
November 2, 2026 23:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
compileActorEgressPolicyfails when any compiler is registered and a tokenPassthrough target has no header. That assumes every registered compiler exists to bind targets, butCompileris a general extension point. A compiler that only adds another header gets its actors denied egress, even when the runtime forwards the caller's token.This removes the binding check, so compilers now own binding each target. The existing policy validation stays.
A compiler that forgets to bind a target now fails at call time instead of at compile time. OSS doesn't register any compilers, so default installs don't change.
Related Issues
None required.
Testing
go test -race ./core/internal/substrate/ ./core/pkg/app/ make -C go lintTestCompileActorEgressPolicyMayLeaveTargetsUnboundcompiles a policy with no extensions and with one that adds another header, and neither binds the target.Change Type
/kind fix
Changelog