Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fullInstall #835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

BecketTrotter
Copy link

Update fullInstall to include the missing final command from 1.7.0-1.7.1

Update fullInstall to include the missing final command from `1.7.0`-`1.7.1`
@BecketTrotter
Copy link
Author

this fixes docker-compose up -d from not working out of the box for me

@lightvector
Copy link
Contributor

Does this actually work for you with only this fix? I'm actually getting a different error from fullInstall a few lines up:

ALTER TABLE `wD_Groups`
	CHANGE COLUMN `type` `type` VARCHAR(50) NOT NULL DEFAULT 'Unknown' AFTER `name`,
	ADD COLUMN `timeMessageRequired` BIGINT UNSIGNED NULL DEFAULT NULL AFTER `timeWeightingRequired`;
ALTER TABLE `wD_GroupUsers`
	ADD COLUMN `isDirty` BIT(1) NOT NULL DEFAULT 0 AFTER `timeCreated`,
	ADD COLUMN `messageCount` SMALLINT UNSIGNED NOT NULL DEFAULT 0 AFTER `isDirty`,
	ADD COLUMN `timeLastMessageSent` BIGINT UNSIGNED NULL DEFAULT NULL AFTER `messageCount`,
	ADD COLUMN `timeWeightingRequired` BIGINT UNSIGNED NULL DEFAULT NULL AFTER `timeLastMessageSent`,
	ADD COLUMN `timeMessageRequired` BIGINT UNSIGNED NULL DEFAULT NULL AFTER `timeWeightingRequired`;

In particular, that wD_Groups does not have a timeWeightingRequired column. This line looks to be copied from the line updating wD_GroupUsers. I it intended that both wD_Groups and wD_GroupUsers have this update? wD_Groups does not have this failing line in the 1.70-1.71 update script.

@BecketTrotter
Copy link
Author

@lightvector I have been docker exec'ing into the Mariadb container and applying the change manually to the DB.
I figured adding it to fullinstall would fix it out of the box.

I have not ran into that timeWeightingRequired error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants