Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #441 - Add MdcAdapter for Cats Effect 3 to properly share context through MDC with IO and IOLocal from Cats Effect 3 #564

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kevin-lee
Copy link
Owner

Summary

Close #441 - Add MdcAdapter for Cats Effect 3 to properly share context through MDC with IO and IOLocal from Cats Effect 3

@kevin-lee kevin-lee added this to the v2-m3 milestone Jan 2, 2025
@kevin-lee kevin-lee self-assigned this Jan 2, 2025
@github-actions github-actions bot added the pr label Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.32%. Comparing base (a0f7da9) to head (b3fc688).

Files with missing lines Patch % Lines
...n/scala/loggerf/logger/logback/Ce3MdcAdapter.scala 96.15% 1 Missing ⚠️
...rf/logger/logback/Ce3MdcAdapterWithIoRuntime.scala 96.29% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   97.66%   97.32%   -0.34%     
==========================================
  Files          15       17       +2     
  Lines         171      224      +53     
  Branches        9       13       +4     
==========================================
+ Hits          167      218      +51     
- Misses          4        6       +2     
Files with missing lines Coverage Δ
...cala/loggerf/logger/logback/Monix3MdcAdapter.scala 88.00% <100.00%> (ø)
...n/scala/loggerf/logger/logback/Ce3MdcAdapter.scala 96.15% <96.15%> (ø)
...rf/logger/logback/Ce3MdcAdapterWithIoRuntime.scala 96.29% <96.29%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MdcAdapter for Cats Effect 3 to properly share context through MDC with IO and IOLocal from Cats Effect 3
1 participant