[BUGFIX] Use the document cache in getDocumentByUid()

[michaelkubina]

Several controllers rely on the retrieval of the document via loadDocument(). The function getDocumentByUid() in the AbstractController.php calls AbstractDocument::getInstance() with the $forceReload parameter being true. With this we never get the actually cached document, but instead force loading the METS-File every time.

I have tracked execution time and the change dropped the 400ms for loadDocument() to about 80ms on a typical document with several hundred pages. Since we use multiple controllers in a details page (pageview, navigation, etc.) this adds up pretty fast.

I believe this is just an oversight, or is there a good reason why this parameter was set to true?

[sebastian-meyer]

This seems fine. I think forcing the reload here is a bug.

@beatrycze-volk Do you know of a good reason why we would do that?

[beatrycze-volk]

This seems fine. I think forcing the reload here is a bug.

@beatrycze-volk Do you know of a good reason why we would do that?

This change is fine. I don#t know why it is like that now, but it should be changed as @michaelkubina proposed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (2ac3a96) to head (eae6acc).
Report is 1 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff      @@
##   main   #1405   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.