Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remove paramater from the magic get function #1412

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[MAINTENANCE] Remove paramater from the magic get function #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Classes/Common/AbstractDocument.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,11 +452,9 @@ abstract protected function magicGetSmLinks(): array;
*
* @abstract
*
* @param bool $forceReload Force reloading the thumbnail instead of returning the cached value
*
* @return string The document's thumbnail location
*/
abstract protected function magicGetThumbnail(bool $forceReload = false): string;
abstract protected function magicGetThumbnail(): string;

/**
* This returns the ID of the toplevel logical structure node
Expand Down
2 changes: 1 addition & 1 deletion Classes/Common/IiifManifest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ protected function ensureHasFulltextIsSet(): void
/**
* @see AbstractDocument::magicGetThumbnail()
*/
protected function magicGetThumbnail(bool $forceReload = false): string
protected function magicGetThumbnail(): string
{
return $this->iiif->getThumbnailUrl();
}
Expand Down
7 changes: 2 additions & 5 deletions Classes/Common/MetsDocument.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,12 +1554,9 @@ protected function magicGetSmLinks(): array
/**
* @see AbstractDocument::magicGetThumbnail()
*/
protected function magicGetThumbnail(bool $forceReload = false): string
protected function magicGetThumbnail(): string
{
if (
!$this->thumbnailLoaded
|| $forceReload
) {
if (!$this->thumbnailLoaded) {
// Retain current PID.
$cPid = $this->cPid ?: $this->pid;
if (!$cPid) {
Expand Down
Loading