-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Fix regression for METS files without physical structure #1417
Conversation
Signed-off-by: Stefan Weil <[email protected]>
Without this fix, anchor or year METS files of periodicals cause a runtime error because they don't have a physical structure. The access to index 1 of the empty array fails ( |
A newspaper may have years where some months are missing. This must not cause a runtime error. Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Related issue: slub/dfg-viewer#327. The modifications were needed to fix runtime errors with anchor and year METS files of newspapers. Those METS files don't contain a physical structure, and there may be missing years and missing months. The additional tests catch these special cases. Even with this pull request, the calendar views still don't work with TYPO3 12, partially because the URL argument tx_dlf[id] is missing (it is replaced by tx_dlf_calendar[id]). The log file shows errors like this one:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. |
No description provided.