Instantiate the CSV parser only once

kitodo · Mar 23, 2024 · dffbffb · dffbffb
1 parent 8fd8d1c
commit dffbffb
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/Kitodo/src/main/java/org/kitodo/production/services/data/MassImportService.java b/Kitodo/src/main/java/org/kitodo/production/services/data/MassImportService.java
@@ -90,13 +90,13 @@ public List<String> getLines(UploadedFile file) throws IOException {
      */
     public List<CsvRecord> parseLines(List<String> lines, String separator) throws IOException, CsvValidationException {
         List<CsvRecord> records = new LinkedList<>();
+        CSVParser parser = new CSVParserBuilder()
+                .withSeparator(separator.charAt(0))
+                .withQuoteChar('\"')
+                .build();
         for (String line : lines) {
             if (!Objects.isNull(line) && !line.isBlank()) {
                 List<CsvCell> cells = new LinkedList<>();
-                CSVParser parser = new CSVParserBuilder()
-                        .withSeparator(separator.charAt(0))
-                        .withQuoteChar('\"')
-                        .build();
                 CSVReader csvReader = new CSVReaderBuilder(new StringReader(line))
                         .withSkipLines(0)
                         .withCSVParser(parser)