Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve info about active metadata editor settings #6356

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

oliver-stoehr
Copy link
Collaborator

This PR replaces the growl message informing about applied settings when opening the editor. The growl prominently blocked the buttons in the upper right corner.
The growl is now removed and replace by two new status icons at the wrench symbol:
Bildschirmfoto 2024-12-20 um 10 54 13
Non filled check: The default setting is active

Bildschirmfoto 2024-12-20 um 10 54 35
Filled check: The task specific setting is active

(Based on proposal from #5888 (comment))

@solth
Copy link
Member

solth commented Jan 9, 2025

@andre-hohmann would you mind checking if this improves the situation for you?

@andre-hohmann
Copy link
Collaborator

andre-hohmann commented Jan 10, 2025

@solth : Thank you very much - in my opinion, this is a very good solution!
It is always recognizable if a setting is active but not annoying.

For traceability, I'm including a GIF showing the function in the way i have applied it.
SettingsMetadataeditor01

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From code reading the changes looks good.

@solth solth merged commit f6f7721 into kitodo:main Jan 10, 2025
5 checks passed
@solth solth deleted the layout-info branch January 10, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants