Repository navigation
recipes: pyjnius: drop stale six dependency - #3379
Merged
Merged
Conversation
f321x
changed the title
f321x
force-pushed
the
202609_pyjnius_drop_six
branch
2 times, most recently
from
September 11, 2026 12:32
16f1ba6 to
0ac6a96
Compare
f321x
force-pushed
the
202609_pyjnius_drop_six
branch
from
October 8, 2026 08:59
236b40d to
bf1f124
Compare
AndreMiras
approved these changes
Oct 8, 2026
AndreMiras
left a comment
AndreMiras
left a comment
Member
There was a problem hiding this comment.
Thanks for this cleanup!
It surfaced a brittle assumption in test_blacklist(). The dependency resolution can select genericndkbuild as a valid alternative, but the test expects the two build orders to differ only by libffi.
I'm preparing a PR (draft) that addresses it refs #3388
Once confirmed and merged let's rebase and merge yours.
AndreMiras
added a commit
to AndreMiras/python-for-android
that referenced
this pull request
Oct 9, 2026
Compare required recipes using the same bootstrap while allowing `genericndkbuild` as a valid dependency choice. Refs kivy#3379
Member
|
Just merged the fix, could you rebase please? |
The six recipe was removed with the Python 3.14 update (kivy#3242), but pyjnius kept 'six' in its depends. A dependency without a recipe is handed to pip as a plain python module, so every build that pulls in pyjnius installs six into the target site-packages for nothing: pyjnius dropped its six requirement in 1.5.0 (kivy/pyjnius#619) and 1.7.0 only declares dev/ci extras.
f321x
force-pushed
the
202609_pyjnius_drop_six
branch
from
October 9, 2026 17:55
bf1f124 to
7711bce
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The six recipe was removed with the Python 3.14 update (#3242), but pyjnius kept 'six' in its depends.
A dependency without a recipe is handed to pip as a plain python module, so every build that pulls in pyjnius installs six into the target site-packages for nothing: pyjnius dropped its six requirement in 1.5.0 (kivy/pyjnius#619) and 1.7.0 only declares dev/ci extras.