-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove unnecessary filter creations #4014
base: main
Are you sure you want to change the base?
feat: remove unnecessary filter creations #4014
Conversation
Signed-off-by: Calum Murray <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4014 +/- ##
==========================================
- Coverage 45.53% 45.51% -0.02%
==========================================
Files 270 270
Lines 19925 19925
==========================================
- Hits 9072 9069 -3
- Misses 10127 10129 +2
- Partials 726 727 +1 ☔ View full report in Codecov by Sentry. |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/test upgrade-tests |
2 similar comments
/test upgrade-tests |
/test upgrade-tests |
/retest |
@Cali0707 can you rebase this? It seems I can't push to your branch to rebase on my own :/ Changes should be like creydr@216fe89 |
This Pull Request is stale because it has been open for 90 days with |
Whoops, I totally missed this. I'll rebase this branch. Sorry! |
Signed-off-by: Cali0707 <[email protected]>
Signed-off-by: Cali0707 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Cali0707: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The filters field is implicitly an
AllFilter
, which means that even if a user only creates a single filter two filters will get created. Similarly, if for some reason a user creates an all filter or any filter with only a single subfilter, we should not create the extra "wrapper" filter.Proposed Changes