Bump Quarkus to 3.15 and align its friends #4214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4214 +/- ##
=======================================
Coverage 45.44% 45.44%
=======================================
Files 270 270
Lines 19893 19893
=======================================
Hits 9041 9041
Misses 10133 10133
Partials 719 719 ☔ View full report in Codecov by Sentry. |
|
Update: Jan 15: The below is fixed. Replaced the issues like this are that we have two different
|
matzew
commented
Jan 14, 2025
| @@ -36,7 +36,8 @@ | |||
| public class MetricsTest { | |||
|
|
|||
| static { | |||
| BackendRegistries.setupBackend(new MicrometerMetricsOptions().setRegistryName(Metrics.METRICS_REGISTRY_NAME)); | |||
| BackendRegistries.setupBackend( | |||
| new MicrometerMetricsOptions().setRegistryName(Metrics.METRICS_REGISTRY_NAME), null); | |||
There was a problem hiding this comment.
hey @tsegismont 👋
Your API changed, based on what I saw for its impl, I am going w/ null as the second argument. (for all the occurrences, in our tests)
matzew
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
pierDipi
reviewed
Jan 15, 2025
data-plane/pom.xml
Outdated
| @@ -42,10 +42,10 @@ | |||
| <spotless.plugin.version>2.38.0</spotless.plugin.version> | |||
|
|
|||
| <!-- dependencies version --> | |||
| <vertx.version>4.5.7</vertx.version> | |||
| <vertx.version>4.5.11</vertx.version> | |||
| <cloudevents.sdk.version>4.0.0</cloudevents.sdk.version> | |||
| <micrometer.version>1.12.5</micrometer.version> | |||
There was a problem hiding this comment.
I see the import change from
import io.micrometer.prometheus.PrometheusConfig;
import io.micrometer.prometheus.PrometheusMeterRegistry;
to
import io.micrometer.prometheusmetrics.PrometheusConfig;
import io.micrometer.prometheusmetrics.PrometheusMeterRegistry;
but the micrometer.version is not changing?
There was a problem hiding this comment.
Ah, yeah. The 1.33.5 is used here, but it comes via quarkus / vertx and their bom.
I guess we can remove the micrometer-bom import at the root pom.xml ?
For now I have changed it on the root pom, and updated the PR
|
Taking a look at the issue |
Looks like some inner of vertx-micrometer still using the "old" |
|
@tsegismont looks like the 4.5.11 version is still on an older While the |
|
That's right. Quarkus uses its own Tracer and Metrics extension. In the Vert.x stack:
In Quarkus -> Micrometer 1.14 (is that correct @brunobat?) |
No, the 3.15.x is is using 1.13.5 -> https://github.com/quarkusio/quarkus/blob/3.15/bom/application/pom.xml#L40 |
OK. But it's 1.13 that's a breaking change release. |
Correct. On Quarkus 3.15, Micrometer 1.13.5 is used. |
matzew
commented
Jan 16, 2025
| @@ -35,6 +35,11 @@ | |||
| <version>${project.version}</version> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
@brunobat @tsegismont this gets me locally around the ClassNotFoundException.
Let's see what the CI says 😅
There was a problem hiding this comment.
I think I could also exclude the other registry-prometheus JAR ...
|
@pierDipi on the What I found interesting is that the other data-plane container (e.g. But actually, nope.. https://github.com/knative-extensions/eventing-kafka-broker/blob/main/data-plane/receiver-loom/pom.xml#L99 |
knative-prow-robot
added
the
needs-rebase
|
@matzew that's the base image |
|
OK, regardless of the base image / container. I have this on the dispatcher: indicating some error w/ the contract. Does this ring a bell, @pierDipi ? |
Update breaking (micrometer/vertx) API calls Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
knative-prow-robot
removed
the
needs-rebase
|
@matzew: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
com.squareup.okhttp3.mockwebserverand exclude old one from fabric8 mock-server, until it has newer version too (like otel)Release Note
Docs