Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rhel/ubi9-openjdk21 runtime image for data plane containers #4217

Merged

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Jan 16, 2025

Fixes #

Proposed Changes

  • as per title

Release Note


Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/data-plane labels Jan 16, 2025
@knative-prow knative-prow bot requested review from aliok and lionelvillard January 16, 2025 15:51
@matzew matzew force-pushed the use_rhel_ubi_base_image branch from fbe6639 to 2d91cd3 Compare January 16, 2025 15:53
@matzew matzew changed the title Use rhel/ubi9-openjdk base image for data plane, as defined in root pom Use rhel/ubi9-openjdk runtimeimage for data plane Jan 16, 2025
@matzew matzew changed the title Use rhel/ubi9-openjdk runtimeimage for data plane Use rhel/ubi9-openjdk21 runtime image for data plane containers Jan 16, 2025
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
Copy link

knative-prow bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.44%. Comparing base (e1e20b7) to head (2d91cd3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4217   +/-   ##
=======================================
  Coverage   45.44%   45.44%           
=======================================
  Files         270      270           
  Lines       19893    19893           
=======================================
  Hits         9041     9041           
  Misses      10133    10133           
  Partials      719      719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Contributor Author

matzew commented Jan 16, 2025

/retest

1 similar comment
@matzew
Copy link
Contributor Author

matzew commented Jan 17, 2025

/retest

@creydr
Copy link
Contributor

creydr commented Jan 17, 2025

/test reconciler-tests

@knative-prow knative-prow bot merged commit eea9a6a into knative-extensions:main Jan 17, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants