You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cmd: invoke reads --file data from disk twice (redundant I/O) #3846
When --file is passed to func invoke, the file contents are read from disk twice:
In newInvokeConfig() (line 280-286) — reads file into cfg.Data
In runInvoke() (line 201-207) — reads the same file again into m.Data
The second read is redundant because m.Data is already initialized from cfg.Data at line 195, which already contains the file contents from the first read. The second read at line 206 just overwrites m.Data with identical content.
Impact
Wasted I/O (file read twice for every invocation with --file)
TOCTOU consistency risk: if the file changes between the two reads, the behavior would be unpredictable
Proposed Fix
Remove the second os.ReadFile block in runInvoke() (lines 200-207). The file is already read into cfg.Data during config creation.
The second read in runInvoke() is not redundant — it's the only one that runs after --confirm prompts may have changed cfg.File. The first read in newInvokeConfig() is the one that's likely unnecessary. I left a more detailed explanation on the PR (#3847).
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
Activity
gauron99 commentedon May 26, 2026
The second read in
runInvoke()is not redundant — it's the only one that runs after--confirmprompts may have changedcfg.File. The first read innewInvokeConfig()is the one that's likely unnecessary. I left a more detailed explanation on the PR (#3847).github-actions commentedon Oct 28, 2026
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with
/reopen. Mark the issue asfresh by adding the comment
/remove-lifecycle stale.