-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 disabled submit button #5070
🔧 disabled submit button #5070
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Code Climate has analyzed commit fdb223c and detected 0 issues on this pull request. View more on Code Climate. |
Nooo it will break the ui 😢 |
What do you mean? I'm not able to submit when input are required. |
I made it disabled because i was able to make collection with empty metadata
I forgot to add disabled to other chains 🥺 |
How? I can't reproduce empty form. |
so, what was the correct behaviour? I also fix the test case in my PR https://github.com/kodadot/nft-gallery/pull/4869/files#diff-fc481224c5f08977e0f26a5aba1fb7a31e0e787e0ddf992b3a71611faf7c0475R12 |
So the correct fix should be on the side of a package |
No disabled pattern
PR Type
Context