Conversation
…r and Button DropdownButton gains `disabled`, `isLoading` (spinner in place of the chevron, trigger disabled and aria-busy) and `variant` / `appearance` / `version` passthrough; billing fell back to a plain Button for the in-flight download. Switch gains `isLoading` (disabled + spinner + aria-busy) and `labels` with on/off text that also names the control; settings composed both around the switch in its webhooks StatusCell. Alert gains `action` (call to action at the right end) and `icon` (replaces the type icon); billing built an AlertBanner from scratch for this layout. Stepper gains `fullWidth`, which stretches the nav and list and gives horizontal steps equal width; dashboard-manager and billing reproduced it with the same `classNames` overrides. Button with `asChild` + `disabled` now marks the child `aria-disabled`, removes it from the tab order and blocks pointer events instead of setting an invalid `disabled` attribute on a link; dashboard-manager swapped the Link for a span and styled it by hand. `shape="pill"` covers the signup PillButton.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five small, independent additions that microfrontends were working around:
disabled,isLoading(spinner replaces the chevron, trigger disabled +aria-busy) andvariant/appearance/versionforwarded to the trigger. Billing (DownloadInvoiceButton) fell back to a plainButtonfor the in-flight download.isLoading(disabled + spinner +aria-busy) andlabels: { on, off }that switch the visible label and the accessible name with the state. Settings (StatusCell) composed both around the switch.action(call to action at the right end) andicon(replaces the type icon). Billing builtAlertBannerfrom scratch for this layout.fullWidthstretches nav and list and gives horizontal steps equal width. Dashboard-manager (SignupStepper) and billing (Stepper) reproduced it with the sameclassNamesoverrides.asChild+disablednow setsaria-disabled,tabIndex=-1andpointer-events-noneon the child instead of an invaliddisabledattribute on a link (dashboard-managerBillingStatCardswapped theLinkfor aspanand styled it by hand).shape="pill"covers the signupPillButton.All defaults unchanged.
Test plan
npx vitest runon the five components (128), lint, types, prettierDropdownButton→States;Switch→StateLabelsAndLoading;Alert→WithAction;Stepper→Horizontal full width;Button/Light/Pill