Conversation
Compute (Collapse), settings (AnimatedHeight) and kubernetes (ExpandableCard, InstalledAppsTab Card) each animate content height with motion, with three different takes on reduced motion, overflow and `aria-controls`. Collapse animates height, opacity and a collapsed margin, drops the duration to zero under `prefers-reduced-motion`, clips overflow only while animating so dropdowns inside are never cut, and with `keepMounted` keeps the region in the DOM (hidden and aria-hidden) so a trigger's `aria-controls` always resolves.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compute (
Collapse), settings (AnimatedHeight) and kubernetes (ExpandableCard, InstalledAppsTabCard) each animate content height with motion, with three different takes on reduced motion, overflow clipping andaria-controls.Collapse(new): animates height, opacity andcollapsedMarginTop; duration drops to zero underprefers-reduced-motion; overflow is clipped only while animating so aSelector tooltip inside is never cut;onExitCompleteafter unmount.keepMounted: keeps the region in the DOM while collapsed (hidden+aria-hidden) so a trigger'saria-controlsalways resolves, the pattern kubernetes documented.motionis already a dependency (Modal).Test plan
onExitComplete, closed by default,keepMountedhidden + aria-hidden, axe (withMotionGlobalConfig.skipAnimations)npx vitest run lib/components/Collapse, lint, types, prettierCollapse(toggle with two Selects inside)