fix: hash only source IP for consistent hash policy - #588
Open
areycruzer wants to merge 1 commit into
Open
areycruzer wants to merge 1 commit into
areycruzer wants to merge 1 commit into
Conversation
Signed-off-by: swyam sharma <swyam7@gmail.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: areycruzer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
Welcome @areycruzer! It looks like this is your first PR to kubeedge/edgemesh 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The consistent-hash load balancer's
useSourceIpmode hashed the fullRemoteAddr()string (IP:port) instead of only the source IP. Because client source ports are ephemeral, the same client could be routed to a different backend on every new connection, defeating session stickiness and violating the IstioConsistentHashLB.useSourceIpcontract.This change extracts only the host from the source address before hashing:
net.SplitHostPort, with a fallback for addresses without a port.netConn.RemoteAddr()fallback behavior is preserved.Regression tests prove the same source IP with different ephemeral ports now selects the same endpoint, for both IPv4 and IPv6, plus error cases for empty/malformed addresses.
Which issue(s) this PR fixes:
Fixes #587
Special notes for your reviewer:
Verified with
go test ./pkg/loadbalancer -count=1under Go 1.19 on Linux (the repository's pinned toolchain).Does this PR introduce a user-facing change?: