Skip to content

fix(pipl): restore rank configuration nesting - #998

Open
diegodevxd wants to merge 1 commit into
kubeedge:mainfrom
diegodevxd:fix/pipl-rank-config
Open

diegodevxd wants to merge 1 commit into
kubeedge:mainfrom
diegodevxd:fix/pipl-rank-config

Conversation

@diegodevxd

@diegodevxd diegodevxd commented Sep 3, 2026

Copy link
Copy Markdown

/kind bug

What this PR does / why we need it

Restores the PIPL benchmark rank configuration so its curated leaderboard columns are passed correctly to Rank.

Root cause

visualization and save_mode were siblings of rank, while selected_dataitem was nested under visualization. BenchmarkingJob._parse_config() therefore did not forward these settings to Rank, causing it to use the default leaderboard selection.

Changes

Moves visualization, selected_dataitem, and save_mode under the existing rank block without changing their configured values.

This PR intentionally scopes the fix to the shipped PIPL configuration. Core-level validation for misplaced or unknown configuration keys is left out of scope and can be addressed separately.

Testing

  • python .github/workflows/validator/validation_runner.py --static --example examples/PIPL/edge-cloud_collaborative_learning_bench
  • YAML regression assertion comparing baseline and patched rank key sets
  • git diff --check

Full PIPL end-to-end execution was not performed because its model/data environment is not available locally.

Addresses #938

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 3, 2026
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

Welcome @diegodevxd! It looks like this is your first PR to kubeedge/ianvs 🎉

@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: diegodevxd
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2026
Signed-off-by: Diego Fernando Mancera Gomez <diegomancera.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants