fix(pipl): restore rank configuration nesting - #998
Open
diegodevxd wants to merge 1 commit into
Open
diegodevxd wants to merge 1 commit into
diegodevxd wants to merge 1 commit into
Conversation
Collaborator
|
Welcome @diegodevxd! It looks like this is your first PR to kubeedge/ianvs 🎉 |
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: diegodevxd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Diego Fernando Mancera Gomez <diegomancera.dev@gmail.com>
diegodevxd
force-pushed
the
fix/pipl-rank-config
branch
from
September 3, 2026 01:03
c5305c4 to
fbd26a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
What this PR does / why we need it
Restores the PIPL benchmark rank configuration so its curated leaderboard columns are passed correctly to
Rank.Root cause
visualizationandsave_modewere siblings ofrank, whileselected_dataitemwas nested undervisualization.BenchmarkingJob._parse_config()therefore did not forward these settings toRank, causing it to use the default leaderboard selection.Changes
Moves
visualization,selected_dataitem, andsave_modeunder the existingrankblock without changing their configured values.This PR intentionally scopes the fix to the shipped PIPL configuration. Core-level validation for misplaced or unknown configuration keys is left out of scope and can be addressed separately.
Testing
python .github/workflows/validator/validation_runner.py --static --example examples/PIPL/edge-cloud_collaborative_learning_benchgit diff --checkFull PIPL end-to-end execution was not performed because its model/data environment is not available locally.
Addresses #938