Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Resolves issue when using task dependent on ParallelFor completion #11476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

farridav
Copy link

Fix issue where tasks preceeding parallel for loops that recieve pipeline parameters, are wrongly expected to have task attributes

Description of your changes:
Im checking to see if the channel input actually has a task before trying to get its name, avoiding an AttributeError that i get otherwise

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign connor-mccarthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @farridav. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@rimolive
Copy link
Member

@farridav Before sending the PR, it would be good ensure that your contribution relies on the KFP code style. You can take a look at https://github.com/kubeflow/pipelines/blob/master/sdk/CONTRIBUTING.md#code-style for more reference.

In the failed test, you need to run this command to understand what you need to change:

yapf --diff sdk/python/kfp/compiler/compiler_utils.py

@hbelmiro
Copy link
Contributor

hbelmiro commented Jan 2, 2025

/ok-to-test

Copy link

github-actions bot commented Jan 2, 2025

Approvals successfully granted for pending runs.

…line parameters, are wrongly expected to have task attributes

Signed-off-by: David Farrington <[email protected]>
@hbelmiro
Copy link
Contributor

hbelmiro commented Jan 2, 2025

/ok-to-test

Copy link

github-actions bot commented Jan 2, 2025

Approvals successfully granted for pending runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants