Skip to content

Allow e2e pod deletion to finish before asserting - #1947

Open
brendandburns with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-e2e-job-failure
Open

brendandburns with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-e2e-job-failure

Conversation

Copilot AI commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

The e2e job failed because ClientSetTest checked for pod removal after only 12.5 seconds, while Kubernetes was still honoring the pod’s 30-second termination grace period.

  • Change: Extend the bounded polling window to 50 seconds in both analogous pod deletion checks.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 15:32
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@kubernetes-prow kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 14, 2026
Copilot AI balanced review requested due to automatic review settings October 14, 2026 15:36
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI changed the title [WIP] Fix failing GitHub Actions job e2e Allow e2e pod deletion to finish before asserting Oct 14, 2026
Copilot AI requested a review from brendandburns October 14, 2026 15:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both deletion checks now allow sufficient time for the default 30-second termination grace period.

0 open findings

🧠 Review effort: Balanced

@brendandburns
brendandburns marked this pull request as ready for review October 14, 2026 16:02
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from tg123 October 14, 2026 16:02
@brendandburns
brendandburns force-pushed the copilot/fix-e2e-job-failure branch from 4750d11 to 0de37d3 Compare October 24, 2026 00:33
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants