Skip to content

Fix devcontainer, Scriban, and xUnit compatibility for NuGet updates - #1967

Merged
brendandburns merged 2 commits into
kubernetes-client:dependabot/nuget/nuget-734a1c6b86from
brendandburns:dependabot/nuget/nuget-734a1c6b86
Oct 17, 2026
Merged

brendandburns merged 2 commits into
kubernetes-client:dependabot/nuget/nuget-734a1c6b86from
brendandburns:dependabot/nuget/nuget-734a1c6b86

Conversation

@brendandburns

Copy link
Copy Markdown
Contributor

Summary

Port the compatibility fixes from #1945 and #1797 onto the dependency-update branch in #1963, preserving its newer package versions.

  • Build the devcontainer with .NET 8, 9, and 10 SDKs.
  • Add PolySharp support and disable Scriban generation limits.
  • Migrate the main client tests to xUnit v3 4.0.0 to match Xunit.StaFact, updating output helpers and OS-specific facts while preserving serial execution and VSTest integration.
  • Remove the unused StaFact reference from the xUnit v2 Kubectl test project.

Validation

  • Client build passed.
  • Focused client regression tests: 32 passed per framework on .NET 8, 9, and 10 (96 total).
  • Kubectl tests build and discover 34 tests per framework; all skip without Minikube.
  • Full client suite was stopped because of long-running watch and leader-election tests; it was not completed.
  • Devcontainer configuration validated; image build not run because Docker is unavailable.

This PR intentionally targets the Dependabot branch, not master.

brendandburns and others added 2 commits October 16, 2026 23:31
…ent#1945

Keep the dependency updates from kubernetes-client#1963 while adding PolySharp support and disabling Scriban generation limits.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match Xunit.StaFact 4 with xunit.v3 4, retain VSTest and serial execution, and update output helpers and OS-specific facts. Remove the unused StaFact reference from the xUnit v2 Kubectl suite.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2026
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from tg123 October 17, 2026 01:14
@brendandburns
brendandburns merged commit 81f6e26 into kubernetes-client:dependabot/nuget/nuget-734a1c6b86 Oct 17, 2026
6 of 7 checks passed
brendandburns added a commit that referenced this pull request Oct 17, 2026
…1967)

* Port devcontainer and Scriban compatibility fixes from #1945

Keep the dependency updates from #1963 while adding PolySharp support and disabling Scriban generation limits.


* Port xUnit v3 migration from #1797

Match Xunit.StaFact 4 with xunit.v3 4, retain VSTest and serial execution, and update output helpers and OS-specific facts. Remove the unused StaFact reference from the xUnit v2 Kubectl suite.


---------
kubernetes-prow Bot pushed a commit that referenced this pull request Oct 17, 2026
* Bump the nuget group with 7 updates

Bumps Microsoft.Bcl.AsyncInterfaces from 10.0.12 to 10.0.13
Bumps Microsoft.TestPlatform.ObjectModel from 18.10.1 to 18.11.0
Bumps OpenTelemetry.Exporter.Console from 1.19.1 to 1.20.0
Bumps OpenTelemetry.Instrumentation.Http from 1.15.1 to 1.20.0
Bumps Scriban from 6.2.1 to 7.5.1
Bumps System.Text.Json from 10.0.9 to 10.0.13
Bumps Xunit.StaFact from 1.2.69 to 4.0.24

---
updated-dependencies:
- dependency-name: Microsoft.Bcl.AsyncInterfaces
  dependency-version: 10.0.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget
- dependency-name: Microsoft.TestPlatform.ObjectModel
  dependency-version: 18.11.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: nuget
- dependency-name: OpenTelemetry.Exporter.Console
  dependency-version: 1.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: nuget
- dependency-name: OpenTelemetry.Instrumentation.Http
  dependency-version: 1.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: nuget
- dependency-name: Scriban
  dependency-version: 7.5.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget
- dependency-name: System.Text.Json
  dependency-version: 10.0.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget
- dependency-name: Xunit.StaFact
  dependency-version: 4.0.24
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix devcontainer, Scriban, and xUnit compatibility for NuGet updates (#1967)

* Port devcontainer and Scriban compatibility fixes from #1945

Keep the dependency updates from #1963 while adding PolySharp support and disabling Scriban generation limits.


* Port xUnit v3 migration from #1797

Match Xunit.StaFact 4 with xunit.v3 4, retain VSTest and serial execution, and update output helpers and OS-specific facts. Remove the unused StaFact reference from the xUnit v2 Kubectl suite.


---------

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brendan Burns <5751682+brendandburns@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant