Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chores:remove unused storage client #7768

Merged

Conversation

MartinForReal
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Chores:remove unused storage client

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.31

@k8s-infra-cherrypick-robot

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.31 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.30

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 9, 2024
@k8s-infra-cherrypick-robot

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.30 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nilo19
Copy link
Contributor

nilo19 commented Dec 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9588eea into kubernetes-sigs:master Dec 9, 2024
18 checks passed
@k8s-infra-cherrypick-robot

@MartinForReal: new pull request created: #7772

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@MartinForReal: #7768 failed to apply on top of branch "release-1.30":

Applying: remove unused storage client
Using index info to reconstruct a base tree...
M	pkg/azureclients/fileclient/azure_fileclient.go
M	pkg/azureclients/privatednszonegroupclient/azure_privatednszonegroupclient_test.go
M	pkg/azureclients/privateendpointclient/azure_privateendpointclient_test.go
M	pkg/azureclients/storageaccountclient/azure_storageaccountclient.go
M	pkg/azureclients/storageaccountclient/azure_storageaccountclient_test.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/version.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/usages.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/tableservices.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/table.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/skus.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/queueservices.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/queue.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/privatelinkresources.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/privateendpointconnections.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/operations.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/objectreplicationpolicies.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/models.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/managementpolicies.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/localusers.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/fileshares.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/fileservices.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/enums.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/encryptionscopes.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/deletedaccounts.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/client.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/blobservices.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/blobinventorypolicies.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/blobcontainers.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/accounts.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/_meta.json
Removing vendor/github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage/CHANGELOG.md
Removing pkg/azureclients/storageaccountclient/mockstorageaccountclient/interface.go
Removing pkg/azureclients/storageaccountclient/mockstorageaccountclient/doc.go
Removing pkg/azureclients/storageaccountclient/interface.go
Removing pkg/azureclients/storageaccountclient/doc.go
CONFLICT (modify/delete): pkg/azureclients/storageaccountclient/azure_storageaccountclient_test.go deleted in remove unused storage client and modified in HEAD. Version HEAD of pkg/azureclients/storageaccountclient/azure_storageaccountclient_test.go left in tree.
CONFLICT (modify/delete): pkg/azureclients/storageaccountclient/azure_storageaccountclient.go deleted in remove unused storage client and modified in HEAD. Version HEAD of pkg/azureclients/storageaccountclient/azure_storageaccountclient.go left in tree.
Removing pkg/azureclients/privateendpointclient/mockprivateendpointclient/interface.go
Removing pkg/azureclients/privateendpointclient/mockprivateendpointclient/doc.go
Removing pkg/azureclients/privateendpointclient/interface.go
Removing pkg/azureclients/privateendpointclient/doc.go
CONFLICT (modify/delete): pkg/azureclients/privateendpointclient/azure_privateendpointclient_test.go deleted in remove unused storage client and modified in HEAD. Version HEAD of pkg/azureclients/privateendpointclient/azure_privateendpointclient_test.go left in tree.
Removing pkg/azureclients/privateendpointclient/azure_privateendpointclient.go
Removing pkg/azureclients/privatednszonegroupclient/mockprivatednszonegroupclient/interface.go
Removing pkg/azureclients/privatednszonegroupclient/mockprivatednszonegroupclient/doc.go
Removing pkg/azureclients/privatednszonegroupclient/interface.go
CONFLICT (modify/delete): pkg/azureclients/privatednszonegroupclient/azure_privatednszonegroupclient_test.go deleted in remove unused storage client and modified in HEAD. Version HEAD of pkg/azureclients/privatednszonegroupclient/azure_privatednszonegroupclient_test.go left in tree.
Removing pkg/azureclients/privatednszonegroupclient/azure_privatednszonegroupclient.go
Removing pkg/azureclients/fileclient/mockfileclient/interface.go
Removing pkg/azureclients/fileclient/mockfileclient/doc.go
Removing pkg/azureclients/fileclient/interface.go
Removing pkg/azureclients/fileclient/doc.go
CONFLICT (modify/delete): pkg/azureclients/fileclient/azure_fileclient.go deleted in remove unused storage client and modified in HEAD. Version HEAD of pkg/azureclients/fileclient/azure_fileclient.go left in tree.
Removing pkg/azureclients/blobclient/mockblobclient/interface.go
Removing pkg/azureclients/blobclient/mockblobclient/doc.go
Removing pkg/azureclients/blobclient/interface.go
Removing pkg/azureclients/blobclient/doc.go
Removing pkg/azureclients/blobclient/azure_blobclient_test.go
Removing pkg/azureclients/blobclient/azure_blobclient.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 remove unused storage client

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants