-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose more health info as well as counts in Apply results #393
Conversation
/test pull-declarative-test |
/assign @justinsb |
PruneFailCount int | ||
HealthyCount int | ||
UnhealthyCount int | ||
Objects []ObjectStatus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these were previously unexported so that we could change the implementation and instead offer higher-level methods (AllApplied, All healthy). What signals do we want to expose? And which objects appear in Objects? One answer could be that we every object in the manifest appears in Objects, and then we populate Applied, Is healthy etc at the object level. But what about objects we are pruning - should they appear in Objects?
I guess the question is ... what do you want to do with this information? Do we have to commit to exposing everything, or can we make more incremental changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mostly want just the objects. Updated the PR to reflect that. Not exposing the counts anymore. Just the list of object status.
ac88472
to
3774c11
Compare
Looks great now, thanks @barney-s /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Expose more health info as well as counts in Apply results
When using applyset as a library we sometimes want more information about the last applied set.
Currently we get boolean (IsHealthy, IsAllApplied).
Having more is useful when consuming this as a library.