Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3633: graduate MatchLabelKeys in PodAffinity to GA #5021

Merged
merged 2 commits into from
Jan 9, 2025
Merged

KEP-3633: graduate MatchLabelKeys in PodAffinity to GA #5021

merged 2 commits into from
Jan 9, 2025
+8 −4

Conversation

sanposhiho
Copy link
Member

  • One-line PR description: KEP-3633: graduate MatchLabelKeys in PodAffinity to GA
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Jan 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2025
@sanposhiho
Copy link
Member Author

/assign @Huang-Wei @alculquicondor

Huang-Wei
Huang-Wei reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The KEP's readme.md needs to be updated as well:

  • Implementation History
  • PRR section
  • Testing coverage
  • etc...

keps/prod-readiness/sig-scheduling/3633.yaml Outdated Show resolved Hide resolved
keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity/kep.yaml Show resolved Hide resolved
@wojtek-t
Copy link
Member

wojtek-t commented Jan 8, 2025

/approve PRR

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2025
@sanposhiho
Copy link
Member Author

@Huang-Wei Updated some parts.

Regarding the test coverage, I don't think we should update? according to:
https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md?plain=1#L291-L293

Huang-Wei
Huang-Wei approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, sanposhiho, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1226bed into kubernetes:master Jan 9, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@Huang-Wei Huang-Wei Huang-Wei approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@alculquicondor alculquicondor

@Huang-Wei Huang-Wei

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Scheduling
Status: Done
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
5 participants
@sanposhiho @wojtek-t @k8s-ci-robot @Huang-Wei @alculquicondor