Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile for Guestbook Application Build #541

Closed
wants to merge 1 commit into from

Conversation

AtharvaNawathe
Copy link

This PR updates the Dockerfile to resolve build errors caused by outdated dependencies.

Issue Addressed:

  • The previous Dockerfile using Go 1.10.0 failed to build due to incompatibilities with newer Go packages, specifically the undefined: any error in github.com/gorilla/mux.

Changes Made:

  • Upgraded to Go 1.18 to ensure compatibility with the latest dependencies.
  • Added Go module initialization to handle package dependencies correctly.

Impact:

  • Resolves build issues and ensures the Dockerfile works with the latest Go ecosystem.
  • Improves the build process and compatibility for the guestbook application.

This update addresses the build error and aligns the Dockerfile with modern Go practices, ensuring a smoother development and deployment experience.

Issue - guestbook go build issue #540

Copy link

linux-foundation-easycla bot commented Aug 7, 2024

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AtharvaNawathe
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from kow3ns and soltysh August 7, 2024 09:02
@k8s-ci-robot
Copy link
Contributor

Welcome @AtharvaNawathe!

It looks like this is your first PR to kubernetes/examples 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/examples has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2024
@AtharvaNawathe
Copy link
Author

/easycla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants