-
Notifications
You must be signed in to change notification settings - Fork 832
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #6542 from ahrtr/add_etcd_group_20240303
Add [email protected] group
- Loading branch information
Showing
4 changed files
with
34 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,6 +168,13 @@ func TestGroupConventions(t *testing.T) { | |
for _, g := range cfg.Groups { | ||
// groups are easier to reason about if email and name match | ||
expectedEmailId := g.Name + "@kubernetes.io" | ||
// sig-etcd keeps using [email protected], but the name "security" | ||
// has already been used by "[email protected]", so we use | ||
// the name "etcd-security". Refer to discussion in | ||
// https://github.com/kubernetes/k8s.io/pull/6542. | ||
if g.Name == "etcd-security" { | ||
expectedEmailId = "[email protected]" | ||
} | ||
if g.EmailId != expectedEmailId { | ||
t.Errorf("group '%s': expected email '%s', got '%s'", g.Name, expectedEmailId, g.EmailId) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,6 +117,9 @@ restrictions: | |
- "^[email protected]$" | ||
- "^[email protected]$" | ||
- "^[email protected]$" | ||
- path: "sig-etcd/groups.yaml" | ||
allowedGroups: | ||
- "@etcd.io$" | ||
- path: "sig-docs/groups.yaml" | ||
allowedGroups: | ||
- "^[email protected]$" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# See the OWNERS docs at https://go.k8s.io/owners | ||
|
||
approvers: | ||
- sig-etcd-leads | ||
reviewers: | ||
- sig-etcd-leads | ||
|
||
labels: | ||
- sig/etcd |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
groups: | ||
- email-id: [email protected] | ||
name: etcd-security | ||
description: |- | ||
Private list for non-public (internal) triage of etcd security vulnerabilities | ||
reported by any etcd contributors or users. | ||
settings: | ||
WhoCanPostMessage: "ANYONE_CAN_POST" | ||
ReconcileMembers: "true" | ||
owners: | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] |