Skip to content

Commit

Permalink
Update test case TestGroupConventions to fix sig-etcd as a special case
Browse files Browse the repository at this point in the history
Signed-off-by: Benjamin Wang <[email protected]>
  • Loading branch information
ahrtr committed Jun 4, 2024
1 parent 7bbb80f commit ff046df
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions groups/groups_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ func TestGroupConventions(t *testing.T) {
for _, g := range cfg.Groups {
// groups are easier to reason about if email and name match
expectedEmailId := g.Name + "@kubernetes.io"
// sig-etcd keeps using [email protected], refer to discussion in
// https://github.com/kubernetes/k8s.io/pull/6542.
if g.Name == "etcd-security" {
expectedEmailId = "[email protected]"
}
if g.EmailId != expectedEmailId {
t.Errorf("group '%s': expected email '%s', got '%s'", g.Name, expectedEmailId, g.EmailId)
}
Expand Down

0 comments on commit ff046df

Please sign in to comment.