Kyverno mutate eks-prow-build-cluster to pull images from ecr

[junshun]

This uses Kyverno to address issue #4928

This was tested using a fake pod manifest and applying the kyverno policy in clusterpolicy.yaml

apiVersion: v1
kind: Pod
metadata:
  name: nginx
spec:
  containers:
  - name: nginx
    image: gcr.io/k8s-prow/nginx:1.14.1
  - name: nginx-staging
    image: gcr.io/k8s-staging-test-infra/nginx:1.14.1
  - name: nginx-others
    image: gcr.io/k8s-others-test-infra/nginx:1.14.1
  - name: nginx-fail
    image: gcr.io/k8s-staging/nginx:1.14.1

It was able to mutate the images to

k describe pod | grep Image:
    Image:          468814281478.dkr.ecr.us-east-2.amazonaws.com/k8s-prow/nginx:1.14.1
    Image:          468814281478.dkr.ecr.us-east-2.amazonaws.com/k8s-staging-test-infra/nginx:1.14.1
    Image:          gcr.io/k8s-others-test-infra/nginx:1.14.1
    Image:          gcr.io/k8s-staging/nginx:1.14.1

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: junshun / name: Jun Shun Zhang (ff6c00e, e308a97)

[k8s-ci-robot]

Welcome @junshun!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @junshun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[upodroid]

/ok-to-test

Thanks. Please sign the CLA

[TerryHowe]

yaml lint isn't digging it.

[upodroid]

@xmudrii Hi, can you deploy these manifests (except the clusterpolicy.yaml file)?

/assign @xmudrii

[xmudrii]

Please change PodDisruptionBudget apiVersion to policy/v1. policy/v1beta1 doesn't exist in Kubernetes 1.25:

resource mapping not found for name: "kyverno" namespace: "kyverno" from "kyverno.yaml": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"

[junshun]

done. Added section to readme about this as well.

[xmudrii]

@upodroid @junshun Applied:

NAME                                          READY   STATUS    RESTARTS        AGE
kyverno-6bfcb5cdfc-99dgp                      1/1     Running   0               2m35s
kyverno-6bfcb5cdfc-lkhgk                      1/1     Running   2 (2m25s ago)   2m35s
kyverno-6bfcb5cdfc-lldts                      1/1     Running   0               2m35s
kyverno-cleanup-controller-85cf97fb88-j9h7v   1/1     Running   0               2m35s

(pod restarts are due to missing CRDs; server-side apply or kubectl create is required because of the annotation length)

[xmudrii]

@junshun The PR needs a rebase (probably because of namespaces.yaml). Can you please rebase it and then we can merge it?

[junshun]

@xmudrii rebased should be good now

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: junshun, xmudrii
Once this PR has been reviewed and has the lgtm label, please assign spiffxp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• infra/aws/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xmudrii]

/assign @ameukam
for approval

[dims]

/hold

Let's make sure we won't see this problem in our build cluster before we land this change - kyverno/kyverno#5830

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xmudrii]

We should eventually get back to this
/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xmudrii]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sftim]

How's this going?

[xmudrii]

@sftim It got blocked on #4994 (comment), but given it worked out without this for a while now, we need to reevaluate if this is something we really need. @upodroid Do you maybe have any feedback on this?

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.