Refactor validation logic around checking for multiple options #17187
+130
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
justinsb
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/api
size/L
|
WIP because I want to validate that this detects that the json names aren't yet right in v1alpha3 (also I need to rebase for kindnet) |
justinsb
force-pushed
the
wip_cleanup_options_checking
branch
from
6b8ec70 to
7df0636
Compare
k8s-ci-robot
removed
the
needs-rebase
justinsb
force-pushed
the
wip_cleanup_options_checking
branch
from
7df0636 to
33a1c37
Compare
We also have to move some of the EnvVar handling around to avoid a circular reference.
justinsb
force-pushed
the
wip_cleanup_options_checking
branch
from
33a1c37 to
5fa9690
Compare
|
/retest |
justinsb
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also have to move some of the EnvVar handling around to avoid a circular reference.