Do not exclude mapped notes

If a note PR get's modified to remove the release note, then the label `release-note-none` will get applied to it. If a map for that note exists, then it will excluded based on that. We now still provide the mapped value to ensure a higher priority over the original PR. Signed-off-by: Sascha Grunert <[email protected]>
kubernetes · Mar 13, 2024 · 41b9e07 · 41b9e07
1 parent 68031dc
commit 41b9e07
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/notes/document/document.go b/pkg/notes/document/document.go
@@ -306,7 +306,7 @@ func New(
 			doc.CVEList = append(doc.CVEList, newcve)
 		}
 
-		if note.DoNotPublish {
+		if !note.IsMapped && note.DoNotPublish {
 			logrus.Debugf("skipping PR %d as (marked to not be published)", pr)
 			continue
 		}

diff --git a/pkg/notes/notes.go b/pkg/notes/notes.go
@@ -136,6 +136,9 @@ type ReleaseNote struct {
 
 	// DataFields a key indexed map of data fields
 	DataFields map[string]ReleaseNotesDataField `json:"-"`
+
+	// IsMapped is set if the note got modified from a map
+	IsMapped bool `json:"is_mapped,omitempty"`
 }
 
 type Documentation struct {
@@ -1146,6 +1149,8 @@ func (rn *ReleaseNote) ApplyMap(noteMap *ReleaseNotesMap, markdownLinks bool) er
 	logrus.WithFields(logrus.Fields{
 		"pr": rn.PrNumber,
 	}).Debugf("Applying map to note")
+	rn.IsMapped = true
+
 	reRenderMarkdown := false
 	if noteMap.ReleaseNote.Author != nil {
 		rn.Author = *noteMap.ReleaseNote.Author