Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s-cloud-builder/k8s-ci-builder to Go 1.21.3 #3319

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Update k8s-cloud-builder/k8s-ci-builder to Go 1.21.3 #3319

merged 1 commit into from
Oct 11, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 11, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Update k8s-cloud-builder/k8s-ci-builder to Go 1.21.3

Which issue(s) this PR fixes:

xref #3311

Does this PR introduce a user-facing change?

Update k8s-cloud-builder/k8s-ci-builder to Go 1.21.3

/assign @cpanato @saschagrunert @jeremyrickard @marosset
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2023
@marosset
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
cpanato
cpanato approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

dependencies.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member

cpanato commented Oct 11, 2023

/hold

I just saw the pros for go updates for the release branches are failing. I think we just need to update the master one and drop the others

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@xmudrii xmudrii changed the title Update k8s-cloud-builder/k8s-ci-builder to Go 1.21.3/1.20.10 Update k8s-cloud-builder/k8s-ci-builder to Go 1.21.3 Oct 11, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Oct 11, 2023

@cpanato Removed 1.20.10 update from this PR

@cpanato
Copy link
Member

cpanato commented Oct 11, 2023

@cpanato Removed 1.20.10 update from this PR

Thanks

@cpanato
Copy link
Member

cpanato commented Oct 11, 2023

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@xmudrii xmudrii force-pushed the cloud-build-1.21.3-1.20.10 branch from af6419b to 5de67ef Compare October 11, 2023 18:09
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2023
@xmudrii xmudrii requested a review from cpanato October 11, 2023 18:11
@marosset
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7b12f3e into kubernetes:master Oct 11, 2023
5 checks passed
@xmudrii xmudrii deleted the cloud-build-1.21.3-1.20.10 branch October 11, 2023 18:45
@cpanato cpanato mentioned this pull request Oct 12, 2023
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@salaxander salaxander Awaiting requested review from salaxander

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

@marosset marosset

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xmudrii @marosset @k8s-ci-robot @cpanato @saschagrunert @jeremyrickard