Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single const for all valid arches #3408

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jan 5, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

My change in #3405, didn't work fully as we are looking for a nonexistent arm image because we are using different arch constants in this repo. I created a new package that holds all the constants and replaced all the hardcoded strings.

https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-build/1743232758513143808/build-log.txt

level=info msg="Digest for gcr.io/k8s-staging-ci-images/conformance:v1.30.0-alpha.0.525_09a5049ca78502 on amd64: sha256:23c85bdf39f3c7332db91c80bae3f269ea831da52c0bd27c7c0bcc0fe4864fde"
level=info msg="Checking image digest for conformance on arm architecture"
level=info msg="The following error(s) occurred while looking for a build: [could not find the image digest for gcr.io/k8s-staging-ci-images/conformance:v1.30.0-alpha.0.525_09a5049ca78502 on arm]"
level=info msg="Proceeding with a new build..."

Which issue(s) this PR fixes:

Special notes for your reviewer:

/cc @xmudrii @cpanato

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 5, 2024
@upodroid upodroid force-pushed the build-correct-arches branch 3 times, most recently from c7627d6 to 1802c67 Compare January 5, 2024 16:29
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 5, 2024
@upodroid upodroid force-pushed the build-correct-arches branch from 859092b to 0aaad17 Compare January 5, 2024 16:55
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2024
@upodroid upodroid force-pushed the build-correct-arches branch 2 times, most recently from 30674b1 to ae16b13 Compare January 5, 2024 18:21
@upodroid upodroid force-pushed the build-correct-arches branch from 57ff8eb to 7240b4e Compare January 5, 2024 18:36
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit bd13f5c into kubernetes:master Jan 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants