-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature gate BtreeWatchCache for v1.32. #49351
base: main
Are you sure you want to change the base?
Conversation
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Try this wording. It's aimed at being close to the wording we'll use once this has graduated (we'd just drop or reword the last line).
Enable this gate will replace the HashMap based implementation of watch cache with a BTree based one. | ||
This replacement may bring performance improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable this gate will replace the HashMap based implementation of watch cache with a BTree based one. | |
This replacement may bring performance improvements. | |
Enable using a BTree to back the _watch cache_ within the Kubernetes API server. | |
If disabled, the API server uses a legacy HashMap-based watch cache. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.