Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gate BtreeWatchCache for v1.32. #49351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jan 8, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
Copy link

netlify bot commented Jan 8, 2025

Pull request preview available for checking

Name Link
🔨 Latest commit 6755efa
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/677e84d5d6e5fb000823bf34
😎 Deploy Preview https://deploy-preview-49351--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Try this wording. It's aimed at being close to the wording we'll use once this has graduated (we'd just drop or reword the last line).

Comment on lines 14 to 15
Enable this gate will replace the HashMap based implementation of watch cache with a BTree based one.
This replacement may bring performance improvements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enable this gate will replace the HashMap based implementation of watch cache with a BTree based one.
This replacement may bring performance improvements.
Enable using a BTree to back the _watch cache_ within the Kubernetes API server.
If disabled, the API server uses a legacy HashMap-based watch cache.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants