Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gate for RelaxedDNSSearchValidation in v1.32 #49355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jan 8, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot requested a review from drewhagen January 8, 2025 12:59
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tengqm. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
Copy link

netlify bot commented Jan 8, 2025

Pull request preview available for checking

Name Link
🔨 Latest commit ef4c902
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/677e76c1c226e1000806f747
😎 Deploy Preview https://deploy-preview-49355--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

defaultValue: false
fromVersion: "1.32"
---
Enabling this gate will relax the server side validation for DNS search string.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enabling this gate will relax the server side validation for DNS search string.
Relax server side validation for the contents of `dnsConfig.searches` for a container within
a Pod.
When this gate is not enabled, Kubernetes enforces a narrower set of DNS names in the search
path; for example, `abc_d.example.com` would be rejected due to the `_` character.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants