Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated the sdk from version 7.3.1 to 7.5.0 #1

Closed
wants to merge 1 commit into from

Conversation

robbertstevens
Copy link

No description provided.

@robbertstevens
Copy link
Author

@demeyerthom I have ran the make command, this was the outcome. Is this something you would expect?

@Bart-Kuipers
Copy link

Hi @demeyerthom would you be able to take a look at this? Thanks

@demeyerthom
Copy link
Member

@robbertstevens @Bart-Kuipers i will take a look tomorrow!

Note that if this is for the commercelayer terraform provider we are still using the original sdk there (https://github.com/incentro-ecx/go-commercelayer-sdk). A switch should be a matter of changing the references in the code, but I had not yet come round to doing that.

Is the intention here to make changes there too?

@Bart-Kuipers
Copy link

@demeyerthom thanks! Yes, the intention is to update the provider to resolve this issue: labd/terraform-provider-commercelayer#10

@robbertstevens
Copy link
Author

@demeyerthom I just saw cl updated the API spec to 7.6.0. I think it's a good idea to run the make command again and instead merge those changes.

Also maybe try to automate it through a GitHub Action.

@Bart-Kuipers fyi

@demeyerthom
Copy link
Member

@robbertstevens @Bart-Kuipers I created a new PR to upgrade to 7.6.1 (they update fast), as well as some hygene stuff we also do in other projects. #2.

I will also create an update in the terraform provider to implement the latest and correct version of the SDK, so I hope you can update your PR there also

@demeyerthom
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants