feat: add shared_secret to market resource #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bart-Kuipers had to make a few adjustments and generated docs, so I took over your branch: #16. I was also inspired to do it a bit differently. I had forgotten that this SDK also returns the response object, so we are still getting the shared secret as part of the body. I deserialize that to fill the secret, which reduces the amount of calls ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
ENHANCEMENTS
Adding the shared_secret on create requires refetching the market after it is created. The CommerceLayer api does return the shared_secret field after creating, but the OpenApi spec does not list it in the response type of the POST/markets call.