ci: update to liblsl v1.18.0.b4 - #124
Merged
Merged
Conversation
Bundled wheels and CI now use the b4 pre-release, which adds lsl_destroy_string_array and stops allocating unfilled string slots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the liblsl used by CI and the bundled wheels to v1.18.0.b4, which adds
lsl_destroy_string_arrayand stops allocating unfilled string chunk slots (sccn/liblsl#302). Updates the README pointer to match.Stacked on #123, which teaches pylsl to use the new bulk free when present. With b4 in CI, the fast path is exercised on all platforms; the per-string fallback is still covered by the monkeypatched test.
No code changes. Asset names and archive layouts are unchanged from b3.
Test plan