Refactor matching_engine (migration from lc monorepo) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RajeshThallam could you take a look, please? |
lkuligin
reviewed
Feb 20, 2024
|
|
||
| from langchain_community.embeddings import TensorflowHubEmbeddings | ||
|
|
||
| return TensorflowHubEmbeddings() |
There was a problem hiding this comment.
should we maybe add a deprecation warning and switch to different default embeddings (VertexAI) so that we can drop dependency on langchain_community completely?
added 2 commits
February 21, 2024 12:40
|
@jzaldi Does the doc/notebook need to be updated or changes are backward compatible? |
|
updating external docs will follow after the release to pypi |
lkuligin
approved these changes
Feb 26, 2024
added 12 commits
February 26, 2024 09:39
lkuligin
force-pushed
the
refactor_matching_engine
branch
3 times, most recently
from
ebef712 to
b4bdc84
Compare
lkuligin
force-pushed
the
refactor_matching_engine
branch
from
b4bdc84 to
8b68a5f
Compare
added 2 commits
February 26, 2024 14:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modular implementation of
VectorStorewith VertexAI components.Migration from PR to LangChain MonoRepo